Also: drivers/staging/unisys/visorbus/periodic_work.c:122 visor_periodic_work_start() warn: bool is not less than zero. drivers/staging/unisys/visorbus/periodic_work.c 107 bool visor_periodic_work_start(struct periodic_work *pw) 108 { 109 bool rc = false; 110 111 write_lock(&pw->lock); 112 if (pw->is_scheduled) { 113 rc = false; 114 goto unlock; 115 } 116 if (pw->want_to_stop) { 117 rc = false; 118 goto unlock; 119 } 120 INIT_DELAYED_WORK(&pw->work, &periodic_work_func); 121 if (queue_delayed_work(pw->workqueue, &pw->work, 122 pw->jiffy_interval) < 0) { ^^^^ 123 rc = false; 124 goto unlock; 125 } 126 pw->is_scheduled = true; 127 rc = true; 128 unlock: 129 write_unlock(&pw->lock); 130 return rc; 131 } regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel