Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote: >> "Gujulan Elango, Hari Prasath (H.)" <hgujulan@xxxxxxxxxxx> writes: >> > Remove the goto and return error directly thereby removing a variable >> > >> > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> >> > --- >> > drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++----- >> > 1 file changed, 2 insertions(+), 5 deletions(-) >> >> NACK! > > SHOUTING! It's normal to write NACK in upper case > >> >> The goto is cleaner and more consistent, rather than hiding a return in >> the middle of the code. > > More consistent with what? There are already returns earlier in the > function. Do-nothing gotos are pointless and annoying. That is *your* preference! Having returns scattered randomly throughout the code is annoying and hard to catch when reading the code! This case is *not* a bug, so it comes down to personal preference of the maintainer. For code you maintain, feel free to do as you like, I will *not* never bother you for this kind of preference issues, I will tell you if I spot an actual bug. This is one of the problems with checkpatch style tools, they have become harassment tools, for some people to impose their personal preferences onto others. It would be so much more valuable if they just focused on real bugs! Jes _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
