Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote:
> > Can't we fix this properly, to use the correct type of pointer instead
> > for non-__iomem allocations?
> 
> You mean making an alternate screen_base pointer inside fb_info that
> isn't __iomem?  There are already a bunch of framebuffer drivers that
> (ab)use screen_base to store non-__iomem pointers, so this didn't
> strike me as too far out of line.

You could add a new pointer or you could just make ->screen_base a
union.  I'm not sure which is the best.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux