Re: [PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On May 3, 2015, at 2:31 PM, Greg KH wrote:

>> -/* Allocations above this size are considered too big and could not be done
>> - * atomically.
>> - *
>> - * Be very careful when changing this value, especially when decreasing it,
>> - * since vmalloc in Linux doesn't perform well on multi-cores system, calling
>> - * vmalloc in critical path would hurt performance badly. See LU-66.
>> - */
>> -#define OBD_ALLOC_BIG (4 * PAGE_CACHE_SIZE)
>> -
>> #define OBD_ALLOC_LARGE(ptr, size)					    \
>> do {									  \
>> -	if (size > OBD_ALLOC_BIG)					     \
>> -		OBD_VMALLOC(ptr, size);				       \
>> -	else								  \
>> -		OBD_ALLOC(ptr, size);					 \
>> +	ptr = libcfs_kvzalloc(size, GFP_NOFS);				  \
>> } while (0)
> 
> Just fix up all callers of these functions, if there are any anymore.

This is what Julia is doing. I am providing the stub for her wonderful scripts to unwrap per her request.

>> + */
>> +/*
>> + * Copyright (c) 2015, Oleg Drokin <green@xxxxxxxxxxxxxx>
> 
> I think your employer would like a different line here...

Only on stuff that I do at work when I am getting paid.

Stuff that I do on my own uncompensated, I own all the rights to, I hope.

Bye,
    Oleg
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux