Re: [PATCH] staging: unisys: fix CamelCase constant names for postcodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 06, 2015 at 10:27:39AM -0400, Benjamin Romer wrote:
> Fix these Camelcase constants:
> 
> VISOR_CHIPSET_PC_controlvm_c => VISOR_CHIPSET_PC_CONTROLVM_C
> VISOR_CHIPSET_PC_controlvm_cm2 => VISOR_CHIPSET_PC_CONTROLVM_CM2
> VISOR_CHIPSET_PC_controlvm_direct_c =>
> 	VISOR_CHIPSET_PC_CONTROLVM_DIRECT_C
> VISOR_CHIPSET_PC_file_c => VISOR_CHIPSET_PC_FILE_C
> VISOR_CHIPSET_PC_parser_c => VISOR_CHIPSET_PC_PARSER_C
> VISOR_CHIPSET_PC_testing_c => VISOR_CHIPSET_PC_TESTING_C
> VISOR_CHIPSET_PC_visorchipset_main_c =>
> 	VISOR_CHIPSET_PC_VISORCHIPSET_MAIN_C
> VISOR_CHIPSET_PC_visorswitchbus_c => VISOR_CHIPSET_PC_VISORSWITCHBUS_C
> VISOR_BUS_PC_businst_attr_c => VISOR_BUS_PC_BUSINST_ATTR_C
> VISOR_BUS_PC_channel_attr_c => VISOR_BUS_PC_CHANNEL_ATTR_C
> VISOR_BUS_PC_devmajorminor_attr_c => VISOR_BUS_PC_DEVMAJORMINOR_ATTR_C
> VISOR_BUS_PC_visorbus_main_c => VISOR_BUS_PC_VISORBUS_MAIN_C
> VISOR_CLIENT_BUS_PC_visorclientbus_main_c =>
> 	VISOR_CLIENT_BUS_PC_VISORCLIENTBUS_MAIN_C
> VIRT_HBA_PC_virthba_c => VIRT_HBA_PC_VIRTHBA_C
> VIRT_PCI_PC_virtpci_c => VIRT_PCI_PC_VIRTPCI_C
> VIRT_NIC_P_virtnic_c => VIRT_NIC_P_VIRTNIC_C
> UISLIB_PC_uislib_c => UISLIB_PC_UISLIB_C
> UISLIB_PC_uisqueue_c => UISLIB_PC_UISQUEUE_C
> UISLIB_PC_uisthread_c => UISLIB_PC_UISTHREAD_C
> UISLIB_PC_uisutils_c => UISLIB_PC_UISUTILS_C
> 
> Reviewed-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> ---
>  drivers/staging/unisys/include/guestlinuxdebug.h | 40 ++++++++++++------------
>  1 file changed, 20 insertions(+), 20 deletions(-)

This breaks the build in horrible ways, which means you didn't even test
build the thing :(

Don't ever do that, please, it interrupts my workflow and I have to go
back and fish out the broken patch and rebuild my tree.

ick ick ick.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux