From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> Sent: Thursday, April 30, 2015 3:05 PM To: Gujulan Elango, Hari Prasath (H.) Cc: devel@xxxxxxxxxxxxxxxxxxxx; Julia.Lawall@xxxxxxx; dan.carpenter@xxxxxxxxxx; Larry.Finger@xxxxxxxxxxxx; florian.c.schilhabel@xxxxxxxxxxxxxx; Babu, Viswanathan (V.) Subject: Re: [PATCH] staging: rtl8712: return error directly On Thu, Apr 30, 2015 at 08:23:08AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > > return error directly to avoid unwanted branching where no cleanup > is done.Also removes the ret variable. signed-off-by goes below the description, not above it. Please fix up and resend. ---- I have sent the v2 patch. regards hari _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel