Re: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to vmbus_process_offer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dexuan Cui <decui@xxxxxxxxxxxxx> writes:

>> -----Original Message-----
>> From: Vitaly Kuznetsov [mailto:vkuznets@xxxxxxxxxx]
>> Sent: Tuesday, April 21, 2015 22:28
>> To: KY Srinivasan
>> Cc: Haiyang Zhang; devel@xxxxxxxxxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx; Dexuan Cui
>> Subject: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to
>> vmbus_process_offer()
>> 
>> We need to call init_vp_index() after we added the channel to the
>> appropriate
>> list (global or subchannel) to be able to use this information when assigning
>> the channel to the particular vcpu. To do so we need to move a couple of
>> functions around. The only real change is the init_vp_index() call. This is a
>> small refactoring without a functional change.
>
> IMO we don't have to move such a big block of code -- we only need to add a
> forward function declaration of init_vp_index()?

Ok, let's make the change smaller. I'll fix and resend, thanks!

>
> Thanks,
> -- Dexuan

-- 
  Vitaly
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux