On Tuesday, April 21, 2015 5:18 AM, Ian Abbott wrote: > Keep the details of the comedi subdevice `runflags` member local to > "comedi_fops.c". In particular, the usage of the > `COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well > with the others. It's used as a marker to indicate the subdevice's > `private` pointer can be automatically freed by the subdevice > clean-up code, whereas the others are associated with the operation of > asynchronous comedi commands. Abstract it's usage away in a couple of > new wrapper functions. > > 1) staging: comedi: wrap COMEDI_SRF_FREE_SPRIV usage > 2) staging: comedi: move COMEDI_SRF_... macros to "comedi_fops.c" > > drivers/staging/comedi/comedi_fops.c | 41 ++++++++++++++++++++-- > drivers/staging/comedi/comedi_internal.h | 1 + > drivers/staging/comedi/comedidev.h | 18 +--------- > drivers/staging/comedi/drivers.c | 2 +- > .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++-- > 5 files changed, 45 insertions(+), 23 deletions(-) Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
