On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote: > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index 54da66d..836386f 100644 > --- a/drivers/hv/channel.c > +++ b/drivers/hv/channel.c > @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, > list_del(&open_info->msglistentry); > spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); > > - if (err == 0) > - newchannel->state = CHANNEL_OPENED_STATE; > + if (err != 0) Doesn't the double negative not make it slightly more confusing? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
