Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On April 3, 2015 1:05:59 PM EDT, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>> 
>> 
>> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
><dan.carpenter@xxxxxxxxxx> wrote:
>> >
>> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,
>struct
>> >net_device *dev)
>> >>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
>> >>  	   ((!ieee->softmac_data_hard_start_xmit &&
>> >>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
>> >> -		printk(KERN_WARNING "%s: No xmit handler.\n",
>> >> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",
>> >
>> >
>> >This should be netdev_warn().  There are a few other similar places.
>> >
>> >regards,
>> >dan carpenter
>> My bad will send in a v2 fixing this. 
>
>Please don't, I'm not going to be taking patches from you any _year_
>soon.
>
>sorry,
>
>greg k-h
Very well then I guess you seem to not trust me no matter how hard I try.  Therefore I will avoid helping out in any subsystems you are a maintainer of. 
Nick 
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux