On Thu, Apr 02, 2015 at 05:03:38PM +0200, vcabanne@xxxxxxxxxxxxxx wrote:
> >From 654380760bfc5b35ed3d3d4a7d3eb126fe747959 Mon Sep 17 00:00:00 2001
> From: Vivien Cabannes <vcabanne@xxxxxxxxxxxxxx>
> Date: Thu, 2 Apr 2015 16:32:15 +0200
> Subject: [PATCH] Staging: lustre: api-ni.c: adding tabs because lines were
> too long.
Remove this.
>
> Adding tabs because lines were too long.
No signed-off-by.
>
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
> index faceb95..4b5d465 100644
> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
> @@ -74,7 +74,8 @@ lnet_get_networks(void)
> int rc;
>
> if (*networks != 0 && *ip2nets != 0) {
> - LCONSOLE_ERROR_MSG(0x101, "Please specify EITHER 'networks' or 'ip2nets' but not both at once\n");
> + LCONSOLE_ERROR_MSG(0x101, "Please specify EITHER 'networks'
> + or 'ip2nets' but not both at once\n");
Don't break up string literals. We want to be able to grep for them.
Also this mangles the printed text.
> return NULL;
> }
>
> @@ -197,7 +198,9 @@ static void lnet_assert_wire_constants(void)
> /* Checks for struct ptl_handle_wire_t */
> CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
> CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
> - CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie) == 8);
> + CLASSERT(
> + (int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie
> + ) == 8);
That's silly. The original is better.
> CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie) == 8);
>
> @@ -1089,8 +1092,9 @@ lnet_startup_lndnis(void)
> LNET_MUTEX_UNLOCK(&the_lnet.ln_lnd_mutex);
>
> if (rc != 0) {
> - LCONSOLE_ERROR_MSG(0x105, "Error %d starting up LNI %s\n",
> - rc, libcfs_lnd2str(lnd->lnd_type));
> + LCONSOLE_ERROR_MSG(0x105,
> + "Error %d starting up LNI %s\n",
> + rc, libcfs_lnd2str(lnd->lnd_type));
Fine.
> lnet_net_lock(LNET_LOCK_EX);
> lnd->lnd_refcount--;
> lnet_net_unlock(LNET_LOCK_EX);
> @@ -1145,8 +1149,9 @@ lnet_startup_lndnis(void)
>
> if (the_lnet.ln_eq_waitni != NULL && nicount > 1) {
> lnd_type = the_lnet.ln_eq_waitni->ni_lnd->lnd_type;
> - LCONSOLE_ERROR_MSG(0x109, "LND %s can only run single-network\n",
> - libcfs_lnd2str(lnd_type));
> + LCONSOLE_ERROR_MSG(0x109,
> + "LND %s can only run single-network\n",
> + libcfs_lnd2str(lnd_type));
Good.
> goto failed;
> }
>
> @@ -1191,7 +1196,8 @@ LNetInit(void)
> LASSERT(the_lnet.ln_cpt_number > 0);
> if (the_lnet.ln_cpt_number > LNET_CPT_MAX) {
> /* we are under risk of consuming all lh_cookie */
> - CERROR("Can't have %d CPTs for LNet (max allowed is %d), please change setting of CPT-table and retry\n",
> + CERROR("Can't have %d CPTs for LNet (max allowed is %d),
> + please change setting of CPT-table and retry\n",
Nope. Bad.
> the_lnet.ln_cpt_number, LNET_CPT_MAX);
> return -1;
> }
> @@ -1753,7 +1759,8 @@ lnet_ping_target_fini(void)
> }
>
> int
> -lnet_ping(lnet_process_id_t id, int timeout_ms, lnet_process_id_t *ids, int n_ids)
> +lnet_ping(lnet_process_id_t id, int timeout_ms, lnet_process_id_t *ids,
> + int n_ids)
Fine.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
