On Thu, Apr 02, 2015 at 12:38:19AM +0700, Phong Tran wrote: > Add the remove() method for deregister from misc device > when it's unloaded. > > Signed-off-by: Phong Tran <tranmanphong@xxxxxxxxx> > --- > drivers/staging/android/ion/ion_test.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c > index 3bc461c..f36a35e 100644 > --- a/drivers/staging/android/ion/ion_test.c > +++ b/drivers/staging/android/ion/ion_test.c > @@ -261,7 +261,25 @@ static int __init ion_test_probe(struct platform_device *pdev) > return 0; > } > > +static int ion_test_remove(struct platform_device *pdev) > +{ > + int ret = 0; Don't initialize variables if you don't need to. Just remove the ret variable completely. > + struct ion_test_device *testdev; > + > + testdev = platform_get_drvdata(pdev); > + > + if (!testdev) { Remove the blank line between the function and the check. They are part of the same thing/paragraph. > + pr_err("failed to get pdev data.\n"); Just leave this error statement out. It will never get printed. It's just a waste of RAM. If it were printed the -ENODATA error is unique to this path so it's all the debug out put we need. > + return -ENODATA; > + } > + > + ret = misc_deregister(&testdev->misc); > + > + return ret; return misc_deregister(&testdev->misc); regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel