On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> Return from rtllib_rx_auth_resp() if auth_parse() fails.
Hello Mateusz. Here are some trivial notes.
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
[]
> + /* Dummy wirless mode setting to avoid
> + * encryption issue */
Please use the typical networking comment style
(and correct the typo too)
/* Dummy wireless mode setting to avoid
* encryption issue
*/
> + if (bSupportNmode) {
> + ieee->SetWirelessMode(ieee->dev,
> + ieee->current_network.mode);
> + } else {
> + /*TODO*/
> + ieee->SetWirelessMode(ieee->dev,
> + IEEE_G);
Many of these multiple line statements can be single line.
> + }
> +
> + if (ieee->current_network.mode ==
> + IEEE_N_24G && bHalfSupportNmode) {
> + netdev_info(ieee->dev,
> + "======>enter half N mode\n");
> + ieee->bHalfWirelessN24GMode =
> + true;
> + } else
> + ieee->bHalfWirelessN24GMode =
> + false;
Single line and better with braces.
> +
> + rtllib_associate_step2(ieee);
> + } else {
> + rtllib_auth_challenge(ieee, challenge,
> + chlen);
> }
> }
Single line.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
