On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > Replace string directly in place of format string and remove pointer
> > variable which was used just once.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> > return err;
> >
> > if (did_version++ == 0) {
> > - dev_info(&pcidev->dev, "%s\n", slic_banner);
> > + dev_info(&pcidev->dev,
> > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
>
> Why make this change? What's wrong with the original code?
>
> There is the issue that driver should be quiet, so really, you can just
> delete all of this nonsense, but that's a different issue here...
You could also use dev_info_once instead.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
