On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote: > Replace string directly in place of format string and remove pointer > variable which was used just once. > > Signed-off-by: Niranjan Dighe <niranjan.dighe@xxxxxxxxx> > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index c2bda1d..f3110f7 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -98,7 +98,6 @@ > #include "slic.h" > > static uint slic_first_init = 1; > -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)"; > > static char *slic_proc_version = "2.0.351 2006/07/14 12:26:00"; > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev, > return err; > > if (did_version++ == 0) { > - dev_info(&pcidev->dev, "%s\n", slic_banner); > + dev_info(&pcidev->dev, > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n"); This indenting looks ugly. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel