Macros with hidden flow control are poor form. Joe Perches (2): staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros drivers/staging/rts5208/Makefile | 2 +- drivers/staging/rts5208/ms.c | 1654 +++++++++++++++++--------- drivers/staging/rts5208/rtsx.c | 6 - drivers/staging/rts5208/rtsx.h | 13 +- drivers/staging/rts5208/rtsx_card.c | 181 ++- drivers/staging/rts5208/rtsx_card.h | 8 +- drivers/staging/rts5208/rtsx_chip.c | 902 ++++++++++---- drivers/staging/rts5208/rtsx_chip.h | 16 - drivers/staging/rts5208/rtsx_scsi.c | 539 ++++++--- drivers/staging/rts5208/rtsx_transport.c | 7 +- drivers/staging/rts5208/sd.c | 1883 +++++++++++++++++++++--------- drivers/staging/rts5208/spi.c | 372 ++++-- drivers/staging/rts5208/trace.c | 26 + drivers/staging/rts5208/trace.h | 61 +- drivers/staging/rts5208/xd.c | 607 +++++++--- 15 files changed, 4382 insertions(+), 1895 deletions(-) create mode 100644 drivers/staging/rts5208/trace.c -- 2.1.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel