Re: [PATCH] staging: rts5208: Fixed 80 char & indent warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct.  :(

True.  Please run your proposed patches through checkpatch
before sending them.

I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.

It would also reduce the code size quite a bit if the TRACE
portion of TRACE_RET/TRACE_GOTO was a separate function and
not an inline.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux