On March 23, 2015 6:40:06 AM EDT, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
>> Fixes the checkpath.pl error where the opening bracket has a unneeded
>space between
>> it and the function name for a if statement in the
>marco,VMX_WAIT_FOR_FIELD32.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> ---
>> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
>b/drivers/staging/octeon-usb/octeon-hcd.c
>> index 1daeb31..0408a12 100644
>> --- a/drivers/staging/octeon-usb/octeon-hcd.c
>> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
>> @@ -412,7 +412,7 @@ struct octeon_hcd {
>> type c; \
>> while (1) { \
>> c.u32 = __cvmx_usb_read_csr32(usb, address); \
>> - if (c.s.field op (value)) { \
>> + if (c.s.field op(value)) { \
>
>"op" is not a function here. This is macro and top is an operation
>like
>"+" or "*". So checkpatch.pl is wrong.
>
>regards,
>dan carpenter
Very well then, I wasn't sure if we did the same spacing style for marcos.
Nick
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
