On Fri, Mar 20, 2015 at 01:52:50PM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 18, 2015 at 05:29:26PM +0000, Ravindran, Madhusudhanan (M.) wrote: > > Since both buffers are null terminated, strncmp > > is not needed. > > How do you know this? How do you ensure it is true? > I followed how the buffers are initialized, and also a similar discussion on using strncmp, http://lists.infradead.org/pipermail/ath10k/2014-March/001469.html > And you shouldn't be relying on a module parameter for anything, please > fix the driver to do things "properly" here, and detect the hardware in > the system. > OK, I will see if I can compare other drivers how they handle this situation. Thanks, Madhu _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
