On Wed, Mar 18, 2015 at 02:23:09PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Wednesday, March 18, 2015 12:27 AM > > To: KY Srinivasan > > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > > olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx; Nick Meier > > Subject: Re: [PATCH 4/9] Correcting truncation error for constant > > HV_CRASH_CTL_CRASH_NOTIFY > > > > On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote: > > > From: Nick Meier <nmeier@xxxxxxxxxxxxx> > > > > > > HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the > > usage context, > > > the value may be truncated. This patch is in response from the following > > > email from Intel: > > > > "from Intel:" is really vague, please be nice and report who told you > > about this problem. > > > > > > > > [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: > > > constant 0x8000000000000000 is so big it is unsigned long > > > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > > char-misc-testing > > > head: b3de8e3719e582f3182bb504295e4a8e43c8c96f > > > commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: > > hv: vmbus: Add support for VMBus panic notifier handler > > > reproduce: > > > # apt-get install sparse > > > git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81 > > > make ARCH=x86_64 allmodconfig > > > make C=1 CF=-D__CHECK_ENDIAN__ > > > > > > sparse warnings: (new ones prefixed by >>) > > > > > > drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so > > big it is unsigned long > > > ... > > > > > > The current char-next branch is broken and this patch fixes > > > the bug. > > > > > > Signed-off-by: Nick Meier <nmeier@xxxxxxxxxxxxx> > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > > > You forgot a "Reported-by:" here. > > Greg, > > Should I resend the set with corrections to this patch. Why wouldn't you? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
