Lorenzo Stoakes <lstoakes@xxxxxxxxx> writes:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:490:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:501:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:502:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:833:5: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces)
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
> ---
> drivers/staging/sm750fb/sm750.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index aa0888c..3e36b6a 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -486,8 +486,8 @@ static int lynxfb_resume(struct pci_dev* pdev)
> par = info->par;
> crtc = &par->crtc;
> cursor = &crtc->cursor;
> - memset(cursor->vstart, 0x0, cursor->size);
> - memset(crtc->vScreen,0x0,crtc->vidmem_size);
> + memset_io(cursor->vstart, 0x0, cursor->size);
> + memset_io(crtc->vScreen,0x0,crtc->vidmem_size);
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes sense to preserve it.
> lynxfb_ops_set_par(info);
> fb_set_suspend(info, 0);
> }
> @@ -498,8 +498,8 @@ static int lynxfb_resume(struct pci_dev* pdev)
> par = info->par;
> crtc = &par->crtc;
> cursor = &crtc->cursor;
> - memset(cursor->vstart, 0x0, cursor->size);
> - memset(crtc->vScreen,0x0,crtc->vidmem_size);
> + memset_io(cursor->vstart, 0x0, cursor->size);
> + memset_io(crtc->vScreen,0x0,crtc->vidmem_size);
the same
> lynxfb_ops_set_par(info);
> fb_set_suspend(info, 0);
> }
> @@ -830,7 +830,7 @@ static int lynxfb_set_fbinfo(struct fb_info* info,int index)
>
> crtc->cursor.share = share;
> - memset(crtc->cursor.vstart, 0, crtc->cursor.size);
> + memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
WARNING: please, no spaces at the start of a line
#137: FILE: drivers/staging/sm750fb/sm750.c:833:
+ memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);$
> if(!g_hwcursor){
> lynxfb_ops.fb_cursor = NULL;
> crtc->cursor.disable(&crtc->cursor);
> @@ -1151,7 +1151,7 @@ static int lynxfb_pci_probe(struct pci_dev * pdev,
> }
> #endif
>
> - memset(share->pvMem,0,share->vidmem_size);
> + memset_io(share->pvMem,0,share->vidmem_size);
the same missing spaces
>
> pr_info("sm%3x mmio address = %p\n",share->devid,share->pvReg);
>
> --
> 2.3.2
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
Vitaly
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
