Greg, you probably missed these :) Could you look at these when you have some time? On 2015.03.13 15:56, Giedrius Statkevičius wrote: > dgnc_ioctl_name() is never used anywhere so remove it > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@xxxxxxxxx> > --- > v2: Forgot to include this patch in the first version. Without this some > of the other patches in this set will fail. > > drivers/staging/dgnc/dgnc_utils.c | 52 --------------------------------------- > drivers/staging/dgnc/dgnc_utils.h | 1 - > 2 files changed, 53 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_utils.c b/drivers/staging/dgnc/dgnc_utils.c > index 80b5133..f76de82 100644 > --- a/drivers/staging/dgnc/dgnc_utils.c > +++ b/drivers/staging/dgnc/dgnc_utils.c > @@ -16,55 +16,3 @@ int dgnc_ms_sleep(ulong ms) > schedule_timeout((ms * HZ) / 1000); > return signal_pending(current); > } > - > -/* > - * dgnc_ioctl_name() : Returns a text version of each ioctl value. > - */ > -char *dgnc_ioctl_name(int cmd) > -{ > - switch (cmd) { > - > - case TCGETA: return "TCGETA"; > - case TCGETS: return "TCGETS"; > - case TCSETA: return "TCSETA"; > - case TCSETS: return "TCSETS"; > - case TCSETAW: return "TCSETAW"; > - case TCSETSW: return "TCSETSW"; > - case TCSETAF: return "TCSETAF"; > - case TCSETSF: return "TCSETSF"; > - case TCSBRK: return "TCSBRK"; > - case TCXONC: return "TCXONC"; > - case TCFLSH: return "TCFLSH"; > - case TIOCGSID: return "TIOCGSID"; > - > - case TIOCGETD: return "TIOCGETD"; > - case TIOCSETD: return "TIOCSETD"; > - case TIOCGWINSZ: return "TIOCGWINSZ"; > - case TIOCSWINSZ: return "TIOCSWINSZ"; > - > - case TIOCMGET: return "TIOCMGET"; > - case TIOCMSET: return "TIOCMSET"; > - case TIOCMBIS: return "TIOCMBIS"; > - case TIOCMBIC: return "TIOCMBIC"; > - > - /* from digi.h */ > - case DIGI_SETA: return "DIGI_SETA"; > - case DIGI_SETAW: return "DIGI_SETAW"; > - case DIGI_SETAF: return "DIGI_SETAF"; > - case DIGI_SETFLOW: return "DIGI_SETFLOW"; > - case DIGI_SETAFLOW: return "DIGI_SETAFLOW"; > - case DIGI_GETFLOW: return "DIGI_GETFLOW"; > - case DIGI_GETAFLOW: return "DIGI_GETAFLOW"; > - case DIGI_GETA: return "DIGI_GETA"; > - case DIGI_GEDELAY: return "DIGI_GEDELAY"; > - case DIGI_SEDELAY: return "DIGI_SEDELAY"; > - case DIGI_GETCUSTOMBAUD: return "DIGI_GETCUSTOMBAUD"; > - case DIGI_SETCUSTOMBAUD: return "DIGI_SETCUSTOMBAUD"; > - case TIOCMODG: return "TIOCMODG"; > - case TIOCMODS: return "TIOCMODS"; > - case TIOCSDTR: return "TIOCSDTR"; > - case TIOCCDTR: return "TIOCCDTR"; > - > - default: return "unknown"; > - } > -} > diff --git a/drivers/staging/dgnc/dgnc_utils.h b/drivers/staging/dgnc/dgnc_utils.h > index cebf601..1164c3a 100644 > --- a/drivers/staging/dgnc/dgnc_utils.h > +++ b/drivers/staging/dgnc/dgnc_utils.h > @@ -2,6 +2,5 @@ > #define __DGNC_UTILS_H > > int dgnc_ms_sleep(ulong ms); > -char *dgnc_ioctl_name(int cmd); > > #endif > -- Thanks, Giedrius _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel