Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.03.2015 09:44, Dan Carpenter wrote:
> On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote:
>> -			RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported"
>> -				 "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT);
>> -						  break;
>> +			RT_TRACE(COMP_RECV,
>> +				 "HwRateToMRate90(): Non supportedRate [%x], bIsHT = %d!!!\n",
> 
> There should be a space character between "supported" and "Rate".  You
> can fix it in a later patch though, it's minor.  And really no one cares
> about RT_TRACE() output.

Thanks for the hint - there is a lot of other typos in messages - I will probably fix them later on;

As for RT_TRACE - my plan is to replace the whole "proprietary logging system" with dynamic debug 
(i.e. netdev_dbg() or pr_debug()), but again - this is bigger patch and I'll prepare it after this series is merged.


Regards,
Mateusz

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux