On Thu, Mar 12, 2015 at 08:08:24PM +0300, Dan Carpenter wrote: > "brd->nasync" amd "brd->maxports" are the same. They hold the number of > filled out channels in the brd->channels[] array. These tests should > be ">=" instead of ">" so that we don't read one element past the end. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/tty/serial/jsm/jsm_cls.c b/drivers/tty/serial/jsm/jsm_cls.c > index bfb0681..4eb12a9 100644 > --- a/drivers/tty/serial/jsm/jsm_cls.c > +++ b/drivers/tty/serial/jsm/jsm_cls.c > @@ -570,7 +570,7 @@ static inline void cls_parse_isr(struct jsm_board *brd, uint port) > * verified in the interrupt routine. > */ > > - if (port > brd->nasync) > + if (port >= brd->nasync) > return; > > ch = brd->channels[port]; > diff --git a/drivers/tty/serial/jsm/jsm_neo.c b/drivers/tty/serial/jsm/jsm_neo.c > index 7291c21..f413ef0 100644 > --- a/drivers/tty/serial/jsm/jsm_neo.c > +++ b/drivers/tty/serial/jsm/jsm_neo.c Hi, Dan. It looks like you missed the fix for neo_parse_isr. Would you send a v2 fixing that as well? Thanks. Cascardo. > @@ -840,7 +840,7 @@ static inline void neo_parse_lsr(struct jsm_board *brd, u32 port) > if (!brd) > return; > > - if (port > brd->maxports) > + if (port >= brd->maxports) > return; > > ch = brd->channels[port]; > @@ -1180,7 +1180,7 @@ static irqreturn_t neo_intr(int irq, void *voidbrd) > */ > > /* Verify the port is in range. */ > - if (port > brd->nasync) > + if (port >= brd->nasync) > continue; > > ch = brd->channels[port]; > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
