On Thu, Mar 12, 2015 at 11:00:10PM +0530, Sudip Mukherjee wrote: > dev_t is defined to be of unsigned int type, no use initializing > it to -1. > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > --- > v2: it was not in v1 > > drivers/staging/unisys/visorchipset/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c > index 9ca7f1e..e9459af 100644 > --- a/drivers/staging/unisys/visorchipset/file.c > +++ b/drivers/staging/unisys/visorchipset/file.c > @@ -30,7 +30,7 @@ > > static struct cdev file_cdev; > static struct visorchannel **file_controlvm_channel; > -static dev_t majordev = -1; /**< indicates major num for device */ > +static dev_t majordev; /**< indicates major num for device */ I don't like this, please fix this up to handle the major number properly, no need for this -1 mess. And you just broke the logic with this change, which isn't allowed in any patch, sorry. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
