Re: [PATCH] staging: sm750fb: Fixed no space warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2015 at 08:48:21PM -0700, Ragavendra Nagraj wrote:
> This patch fixes the no spaces warning identified by the checkpath.pl
> script for the entire ddk750_chip.c file by using appropriate tab spaces
> instead.

its definitely better than your first submission  :)
but ... 
i have not fully checked your patch. there seems to be issues with
indention which will introduce some new checkpatch warnings.
just marking a few inline.

> 
> Signed-off-by: Ragavendra Nagraj <ragavendra.bn@xxxxxxxxx>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c |  364 ++++++++++++++++-----------------
>  1 file changed, 182 insertions(+), 182 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index b71169e..4567e08 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -20,22 +20,22 @@ logical_chip_type_t getChipType()
>  	physicalID = devId750;//either 0x718 or 0x750
>  	physicalRev = revId750;
>  
> -    if (physicalID == 0x718)
> -    {
> -        chip = SM718;
> -    }
> -    else if (physicalID == 0x750)
> -    {
> -        chip = SM750;
> +	if (physicalID == 0x718)
> +	{
> +	chip = SM718;
you lost the indention here.
> +	}
> +	else if (physicalID == 0x750)
> +	{
> +	chip = SM750;
and here
>  		/* SM750 and SM750LE are different in their revision ID only. */
>  		if (physicalRev == SM750LE_REVISION_ID){
>  			chip = SM750LE;
>  		}
> -    }
> -    else
> -    {
> -        chip = SM_UNKNOWN;
> -    }
> +	}
> +	else
> +	{
> +	chip = SM_UNKNOWN;
and here
> +	}
>  
>  	return chip;
>  }
> @@ -43,63 +43,63 @@ logical_chip_type_t getChipType()
>  
>  inline unsigned int twoToPowerOfx(unsigned long x)
>  {
> -    unsigned long i;
> -    unsigned long result = 1;
> +	unsigned long i;
> +	unsigned long result = 1;
>  
> -    for (i=1; i<=x; i++)
> -        result *= 2;
> -    return result;
> +	for (i=1; i<=x; i++)
> +	result *= 2;
and here.

i think you got the problem. so not checking any more.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux