Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ragavendra,

On 2015.03.14 03:04, Ragavendra Nagraj wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl. Please accept.

The "Please accept." part is unnecessary. We don't want that in a commit
log forever. Also, you fix a lot of coding style issues in one commit or
IOW more than one type of change in one commit.  What you could do
instead is fix one type of coding style issue in a commit for the whole
file and do that for each coding style issue. So that would result in 3
patches instead of this one. Could you do that and resend?

[...]

-- 
Thanks,
Giedrius
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux