MAJOR(majordev) is 0 when dynamic major number is used, and it is greater than 0 when static major number is used. Considering both the cases the expression is always true. Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> --- v2: changed commit log drivers/staging/unisys/visorchipset/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c index e9459af..e88a215 100644 --- a/drivers/staging/unisys/visorchipset/file.c +++ b/drivers/staging/unisys/visorchipset/file.c @@ -82,10 +82,8 @@ visorchipset_file_cleanup(void) cdev_del(&file_cdev); file_cdev.ops = NULL; if (registered) { - if (MAJOR(majordev) >= 0) { - unregister_chrdev_region(majordev, 1); - majordev = MKDEV(0, 0); - } + unregister_chrdev_region(majordev, 1); + majordev = MKDEV(0, 0); registered = FALSE; } } -- 1.8.1.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel