Marcus Folkesson <marcus.folkesson@xxxxxxxxx> writes:
> This patch fixes the following sparse warnings:
>
> CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
> cast to restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning:
> cast to restricted __le16
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> ---
> drivers/staging/rtl8723au/include/rtl8723a_hal.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/include/rtl8723a_hal.h b/drivers/staging/rtl8723au/include/rtl8723a_hal.h
> index e146336..f642b11 100644
> --- a/drivers/staging/rtl8723au/include/rtl8723a_hal.h
> +++ b/drivers/staging/rtl8723au/include/rtl8723a_hal.h
> @@ -255,10 +255,10 @@ struct hal_data_8723a {
> struct hal_version VersionID;
> enum rt_customer_id CustomerID;
>
> - u16 FirmwareVersion;
> - u16 FirmwareVersionRev;
> - u16 FirmwareSubVersion;
> - u16 FirmwareSignature;
> + __le16 FirmwareVersion;
> + __le16 FirmwareVersionRev;
> + __le16 FirmwareSubVersion;
> + __le16 FirmwareSignature;
Ehm I am pretty sure it doesn't:
rtl8723au_hal_init.c:265
pHalData->FirmwareVersion = le16_to_cpu(pFwHdr->Version);
pHalData->FirmwareSubVersion = pFwHdr->Subversion;
pHalData->FirmwareSignature = le16_to_cpu(pFwHdr->Signature);
If anything, the second assignment there should be changed to use
le16_to_cpu(), but your conversion is definitely wrong.
NACK
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
