Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
>  static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf)
>  {
> -	struct dgnc_board *bd;
> -	int count = 0;
> -	int i = 0;
> -
> -	DGNC_VERIFY_BOARD(p, bd);
> +	int count = 0, i = 0;

Don't redo the patch, but really these should be on separate lines.
This is an unwritten rule.  :)  Also there is no need to set "i".

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux