On Tue, Mar 10, 2015 at 03:05:26PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Tuesday, March 10, 2015 12:42 AM > > To: KY Srinivasan > > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > > olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx > > Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the > > vmbus_sendpacket_pagebuffer_ctl() > > > > On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: > > > Export the vmbus_sendpacket_pagebuffer_ctl() interface. > > > > Why? Nothing in this patch needs it. Please include this in the patch that > > needs the symbol, or at least give a hint as to what is going on. > > > > As it is, this just looks like a random export for no reason at all :( > > This will be used by Hyper-V networking driver to optimize signaling on > the send path. I wanted these patches committed before I sent the networking > patch to David Miller. I implemented the two vmbus APIs for sending messages: > 1) vmbus_sendpacket_ctl() > 2) vmbus_sendpacket_pagebuffer_ctl() > > and I forgot to export the second form of the send API in an earlier patch-set that you have > already committed. I need both to be exported to > for the netvsc patch I have. Then just send it as part of the netvsc patches please. > On a different note, upstream Linux is currently broken on Hyper-V and a patch in this set > Fixes it: > 0002-Drivers-hv-vmbus-Perform-device-register-in-the-per-.patch That should have been pointed out somewhere :) > Do you want me to resend this set? Yes, please do. Break it up into two different sets, one for 4.0-final, and one for 4.1-rc1. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
