On Mon, Mar 09, 2015 at 08:57:08PM +0000, Lorenzo Stoakes wrote: > > +#include <asm/io.h> > + apart from what Dan Carpenter has said, this is introducing one checkpatch warning, better to use #include <linux/io.h> checkpatch is also giving warning about your patch subject only one concern - if Greg first applies the patches i sent yesterday then this patch will not apply, and if this one is applied first then my series will not apply ... regards sudip > /* This is all the chips recognized by this library */ > mmio750 = addr; > devId750 = devId; > -- > 2.3.2 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel