[PATCH 0/4] staging/lustre: checkpatch cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Mario J. Rugiero" <mrugiero@xxxxxxxxx>

Hi, as listed in the todo for this driver is fixing checkpatch 
warnings, I wrote this patchset which fixes the following issues on all 
of the driver files, one patch per issue:
trailing semicolons in macros
uses of __attribute__((format(printf,...)) instead of __printf(...)
uses of __attribute__(aligned(size)) insted of __aligned(size)
uses of __attribute__((packed)) instead of __packed

Each patch should be pretty much self-contained.

As I'm aware that my communication skills aren't the best, aside from 
the obvious criticism of patches, constructive criticism on how to 
communicate better with the list is accepted as well. If I broke any 
netiquette (I did my best, but something might have slipped), I'm also 
open to hearing.

Thanks a lot in advance,
Mario.

Mario J. Rugiero (4):
  staging/lustre: checkpatch cleanup: macros should not use a trailing
    semicolon
  staging/lustre: checkpatch cleanup: __printf(string-index,
    first-to-check) is preferred over __attribute__((format(printf,
    string-index, first-to-check)))
  staging/lustre: checkpatch cleanup: __aligned(size) is preferred over
    __attribute__((aligned(size)))
  staging/lustre: checkpatch cleanup: __packed is preferred over
    __attribute__((packed))

 .../lustre/include/linux/libcfs/libcfs_debug.h     |  6 +--
 .../include/linux/libcfs/libcfs_kernelcomm.h       |  4 +-
 .../lustre/include/linux/libcfs/libcfs_private.h   |  4 +-
 .../staging/lustre/include/linux/lnet/lib-types.h  |  2 +-
 .../staging/lustre/lustre/include/lprocfs_status.h |  6 +--
 drivers/staging/lustre/lustre/include/lu_object.h  |  2 +-
 .../lustre/lustre/include/lustre/lustre_idl.h      | 44 +++++++++++-----------
 .../lustre/lustre/include/lustre/lustre_user.h     | 14 +++----
 drivers/staging/lustre/lustre/include/lustre_dlm.h |  2 +-
 drivers/staging/lustre/lustre/include/lustre_net.h |  2 +-
 10 files changed, 43 insertions(+), 43 deletions(-)

-- 
2.3.2

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux