we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.
Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
---
v2: added the error message if parport_register_driver() fails.
drivers/staging/panel/panel.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3ef3dcf..65872fa 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2254,7 +2254,7 @@ static struct parport_driver panel_driver = {
/* init function */
static int __init panel_init_module(void)
{
- int selected_keypad_type = NOT_SET;
+ int selected_keypad_type = NOT_SET, err;
/* take care of an eventual profile */
switch (profile) {
@@ -2360,9 +2360,10 @@ static int __init panel_init_module(void)
return -ENODEV;
}
- if (parport_register_driver(&panel_driver)) {
+ err = parport_register_driver(&panel_driver);
+ if (err) {
pr_err("could not register with parport. Aborting.\n");
- return -EIO;
+ return err;
}
if (pprt)
--
1.8.1.2
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
