On Mon, Mar 09, 2015 at 02:53:37PM +0300, Dan Carpenter wrote: > On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote: > > > > V2: Giedrius commented resource_size_t can be either u64 or u32 > > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i > > should have kept the datatype as resource_size_t and used %pa as the > > format specifier. But since this is a framebuffer device and it > > should follow what the framebuffer layer is suggesting in > > struct fb_fix_screeninfo at smem_start and mmio_start. > > adding Tomi for his comments. > > > This should all have gone into the changelog because it changes how the > code works. ok, then should i send a v3 of only this patch or the whole series? regards sudip > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel