On Mon, Mar 09, 2015 at 07:47:40AM +0000, Lad, Prabhakar wrote: > On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee > <sudipm.mukherjee@xxxxxxxxx> wrote: > > check if it is already defined before defining SM750LE_REVISION_ID > > again and at the same time mention correct data type. > > > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > --- > > > > v2: removed the redundant cast in sm750_hw.c > > > > drivers/staging/sm750fb/ddk750_chip.h | 4 +++- > > drivers/staging/sm750fb/sm750_hw.c | 2 +- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h > > index 1c78875..d761b72 100644 > > --- a/drivers/staging/sm750fb/ddk750_chip.h > > +++ b/drivers/staging/sm750fb/ddk750_chip.h > > @@ -1,7 +1,9 @@ > > #ifndef DDK750_CHIP_H__ > > #define DDK750_CHIP_H__ > > #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ > > -#define SM750LE_REVISION_ID (char)0xfe > > +#ifndef SM750LE_REVISION_ID > > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > > BTW who is defining this somewhere else ? it is defined in ddk750_chip.h which is again being used by ddk750_chip.c . regards sudip > > Cheers, > --Prabhakar Lad _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
