Re: [PATCH 4/4] staging: sm750fb: fix undeclared function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015.03.08 14:31, Sudip Mukherjee wrote:
> kbuild test robot reported that for microblaze-allyesconfig
> chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> functions were defined under CONFIG_PM, so for any archtecture if
> CONFIG_PM is not defined we will have this error.
> while moving the lynxfb_suspend() function some very obvious
> checkpatch errors were taken care of.

Such as? If you do you could also fix up the poor things with that
function too such as the comment style here (no space between ; and the
comment):

> +		if (info)
> +			fb_set_suspend(info, 1);/* 1 means do suspend*/
> +

or here (extra unneeded spaces):

> +
> +		/* set chip to sleep mode	*/
> +		if (share->suspend)
> +			(*share->suspend)(share);

-- 
Thanks,
Giedrius
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux