Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/07/2015 09:33 AM, Matteo Semenzato wrote:
From: Matteo Semenzato <mattew8898@xxxxxxxxx>

The rtw_cmd_thread semaphore was being unlocked twice.

Signed-off-by: Matteo Semenzato <mattew8898@xxxxxxxxx>
---
  drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 4b43462..43a8515 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -173,7 +173,7 @@ int rtw_cmd_thread(void *context)
  	allow_signal(SIGTERM);

  	pcmdpriv->cmdthd_running = true;
-	up(&pcmdpriv->terminate_cmdthread_sema);
+	down(&pcmdpriv->terminate_cmdthread_sema);

  	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));

I get nervous when I see patch 2/2 immediately resent as a single patch. What is going on?

Have you actually tested this patch, or did you find this with some static checker?

Larry


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux