[PATCH v4 0/6] staging: unisys: remove logging macros from all drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch series removes all of the logging macros from the Unisys driver set,
as well as the ASSERT() macro, which was really just a wrapper around a log
macro.

Log and error messages deemed necessary for the user will be added back in using
standard kernel logging functions by future patches.

v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs when the then clause was only one statement.

v3 - Fixed the doubled tabs missed in v2, and added a patch for removing the
ASSERT() macro.

v4 - Fixed a line that was incorrectly removed, reversed the test in WARN_ON(),
removed a redundant atomic_read(), and fixed an accidental behavior change where
removing the error printout changed the flow of a function.

Benjamin Romer (6):
  staging: unisys: remove DBGINF, DBGVER, DEBUGDEV, and DEBUGDRV macros
  staging: unisys: remove LOGINF macros
  staging: unisys: remove ASSERT() macro
  staging: unisys: remove LOGVER macro
  staging: unisys: remove ERRDEV macros
  staging: unisys: remove LOGWRN() macros and uniklog.h

 drivers/staging/unisys/include/procobjecttree.h    |   1 -
 drivers/staging/unisys/include/timskmod.h          |  16 --
 drivers/staging/unisys/include/uisqueue.h          |   1 -
 drivers/staging/unisys/include/uisutils.h          |   2 -
 drivers/staging/unisys/include/uniklog.h           | 191 ---------------
 drivers/staging/unisys/uislib/uislib.c             | 193 ++-------------
 drivers/staging/unisys/uislib/uisqueue.c           |   6 +-
 drivers/staging/unisys/uislib/uisthread.c          |   6 -
 drivers/staging/unisys/uislib/uisutils.c           |   6 -
 drivers/staging/unisys/virthba/virthba.c           | 223 ++---------------
 drivers/staging/unisys/virtpci/virtpci.c           | 231 +++---------------
 drivers/staging/unisys/visorchannel/globals.h      |   1 -
 .../unisys/visorchannel/visorchannel_funcs.c       |  66 ++---
 .../unisys/visorchannel/visorchannel_main.c        |   2 -
 drivers/staging/unisys/visorchipset/file.c         |  36 +--
 drivers/staging/unisys/visorchipset/globals.h      |   1 -
 drivers/staging/unisys/visorchipset/parser.c       |  66 +----
 drivers/staging/unisys/visorchipset/parser.h       |   1 -
 .../unisys/visorchipset/visorchipset_main.c        | 268 +++------------------
 drivers/staging/unisys/visorutil/charqueue.c       |   5 +-
 drivers/staging/unisys/visorutil/charqueue.h       |   1 -
 drivers/staging/unisys/visorutil/easyproc.c        |  27 +--
 .../staging/unisys/visorutil/memregion_direct.c    |  37 +--
 drivers/staging/unisys/visorutil/periodic_work.c   |  15 +-
 drivers/staging/unisys/visorutil/procobjecttree.c  |  25 +-
 drivers/staging/unisys/visorutil/visorkmodutils.c  |   1 -
 26 files changed, 175 insertions(+), 1253 deletions(-)
 delete mode 100644 drivers/staging/unisys/include/uniklog.h

-- 
2.1.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux