Re: [PATCH v3 3/6] staging: unisys: remove ASSERT() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 03, 2015 at 10:50:40AM -0500, Benjamin Romer wrote:
>  #define sizeofmember(TYPE, MEMBER) (sizeof(((TYPE *)0)->MEMBER))
>  /** "Covered quotient" function */
>  #define COVQ(v, d)  (((v) + (d) - 1) / (d))
> diff --git a/drivers/staging/unisys/visorutil/periodic_work.c b/drivers/staging/unisys/visorutil/periodic_work.c
> index 0908bf9..30c4248 100644
> --- a/drivers/staging/unisys/visorutil/periodic_work.c
> +++ b/drivers/staging/unisys/visorutil/periodic_work.c
> @@ -182,7 +182,7 @@ BOOL visor_periodic_work_stop(struct periodic_work *pw)
>  			/* We get here if the delayed work was pending as
>  			 * delayed work, but was NOT run.
>  			 */
> -			ASSERT(pw->is_scheduled);
> +			WARN_ON(pw->is_scheduled);

This test is reversed.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux