On Tue, Mar 03, 2015 at 03:36:17AM +0000, Cláudio Maia wrote: > The following errors were fixed: > > ERROR: code indent should use tabs where possible > WARNING: line over 80 characters > > Signed-off-by: Cláudio Maia <crrm@xxxxxxxxxxx> Don't indent this. > @@ -52,60 +52,63 @@ static int init_display(struct fbtft_par *par) > par->fbtftops.reset(par); > > /* Function set */ > - write_reg(par, 0x21); /* 5:1 1 > - 2:0 PD - Powerdown control: chip is active > - 1:0 V - Entry mode: horizontal addressing > - 0:1 H - Extended instruction set control: extended > - */ > + write_reg(par, 0x21); /* > + 5:1 1 > + 2:0 PD - Powerdown control: chip is active > + 1:0 V - Entry mode: horizontal addressing > + 0:1 H - Extended instruction set control: extended > + */ This looks kind of weird and this is not kernel style for commenting. Read Documentation/CodingStyle. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel