On Mon, Mar 02, 2015 at 11:46:57AM +0300, Dan Carpenter wrote: > On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote: > > On 02/27/2015 10:44 AM, Matteo Semenzato wrote: > > >From: Matteo Semenzato <mattew8898@xxxxxxxxx> > > > > > >This patch fixes the following errors: > > >ERROR: space prohibited before that ',' (ctx:WxW) > > >ERROR: space prohibited before that ',' (ctx:WxW) > > >ERROR: switch and case should be at the same indent > > > > > >Signed-off-by: Matteo Semenzato <mattew8898@xxxxxxxxx> > > > > I appreciate your efforts, but you are not improving the source. > > Running scripts/checkpatch.pl against your patch results in the > > following summary: > > > > total: 60 errors, 32 warnings, 352 lines checked > > > > You have fixed 60 errors, and introduced 60 new ones. :( > > That's weird. I only get the 32 warnings. Those are all long line > warnings which were there in the original code as well. yes, same here. I didn't get any new warnings. But since Matteo Semenzato is sending a new patch so i chose not to reply. regards sudip > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
