On Wed, Feb 18, 2015 at 05:37:55PM -0300, Mario J. Rugiero wrote:
> This fixes all appearances of the warning but one, as that one seems to be
> intentional:
>
> WARNING: Single statement macros should not use a do {} while (0) loop
> #1221: FILE: lustre/include/lustre_dlm.h:1221:
> +#define LDLM_LOCK_RELEASE(lock) \
> +do { \
> + /*LDLM_DEBUG((lock), "put");*/ \
> + ldlm_lock_put(lock); \
> +} while (0)
>
> I didn't know if I should touch this debug statement, and if uncommented it
> would certainly be incorrect to erase the do-while construct.
>
> Regards,
> Mario.
> >From 01a11dfacba84065a69deed929acaa84d249b7b5 Mon Sep 17 00:00:00 2001
> From: "Mario J. Rugiero" <mrugiero@xxxxxxxxxxxxxxxxxx>
> Date: Wed, 18 Feb 2015 17:23:39 -0300
> Subject: [PATCH] Lustre: single statement macros should not use a do {} while
> (0) loop.
Why is this here, and there is no changelog info here?
Please fix up and resend.
thanks,
greg k-h-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
