On Thu, 2015-02-26 at 20:37 +0300, Dan Carpenter wrote: > There is only one place which calls this ASSERT() macro. It should > probably be changed to: > > WARN_ON(!pw->is_scheduled); I can do that in a subsequent patch, but my intent was to remove the logging macros, not to fix the functions using them. If I have to fix the functions first before removing the macros it'd be a better use of time to just remove them as part of refactoring each function, and not try to do an across the board patch like this. > Double tab. Yes, I missed a couple - I will fix these... > Is this really necessary? I don't know for sure since I'm not the original author of this code, all I was doing was removing the logging macros. I can try to find the person who wrote it and see if the function can be simplified any, but again, if each function I touch needs to be fixed before I can remove the logging, there's no point trying to remove the logging macros across the board. > Gotta run... Enough reviewing for tonight. Thanks, I appreciate the help. :) -- Ben _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
