Re: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 20, 2015 at 06:43:53PM +0530, Tapasweni Pathak wrote:
> To avoid deadlock, do not call blocking functions with spinlocks held.
> 
> Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
> doesn't have enough free pages but will not sleep and hence deadlock can
> be avoided.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@xxxxxxxxx>
> ---
> Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?

No, this is fine, nice fix.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux