Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> Clean up Makefile by removing unnecessary definition of DG_NAME.
> 
> Signed-off-by: Cass May <cass@xxxxxxxxx>
> ---
> Having done some build tests, it seems that DG_NAME is not needed, 
> but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, 
> and moved the latter into the appropriate header. 

Thanks!

Don't resend; this patch is great.  But next time just fold both patches
together into one patch.  It's all part of the same fix really so it
falls into the "one thing per patch" rule.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux