On Fri, Feb 13, 2015 at 1:05 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > You're doing too many things at one. This should probably be split into > 7 patches. I will split this up and resubmit. > > >> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> if (ed->dev_ed == ed->host_ed) >> return x; >> >> - return Endian16_Swap(x); >> + return ENDIAN16_SWAP(x); >> } > > All the changes are good except these. We have standard macros > cpu_to_be16()/le16() and back for these. > > regards, > dan carpenter Thanks, I'll skip this one. Regards, Tolga Ceylan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
