Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@xxxxxxxxx>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.

I don't understand what this means.

> 

1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.

regards,
dan carpenter 

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux