Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you, I'll resubmit this with additional corrections to format strings.

On Sun, Feb 8, 2015 at 1:54 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote:
>> Lines over 80 were corrected
> []
>> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> []
>> @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, HT_CHANNEL_WIDTH Bandwidth)
> []
>> +                     /* 8256 D-cut, E-cut, xiong: consider it later! */
>> +                     if (priv->card_8192_version == VERSION_819xU_A
>> +                             || priv->card_8192_version == VERSION_819xU_B) {
>
> This is more commonly written:
>
>                         if (priv->card_8192_version == VERSION_819xU_A ||
>                             priv->card_8192_version == VERSION_819xU_B) {
>
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux