On Thu, Feb 05, 2015 at 04:57:09PM +0000, Lad, Prabhakar wrote:
> On Thu, Feb 5, 2015 at 4:30 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote:
> >
> >> On a serious note: I do understand what you're getting at, I don't take
> >> that personally (and I will send a v2 addressing the things above), but
> >> honestly, this kind of answer might just be a real turn-off for other
> >> people trying to get into kernel development...
> >>
> >> I don't want to start a whole new 'attitude in the kernel community'
> >> discussion, but I can't just let this go like that, sorry.
> >
> > Just during the last 12 hours or so, I've seen the following l-k traffic:
> >
> > Subject: [PATCH] usb: host/sl811-hcd: fix sparse warning
> > Subject: [PATCH] usb: gadget: function/f_sourcesink: fix sparse warning
> > Subject: [PATCH] tty: vt/vt: fix sparse warning
> > Subject: [PATCH] scsi: fix sparse warnings
> > Subject: [PATCH] bfa: bfa_core: fix sparse warning
> > Subject: [PATCH] scsi: fix sparse warning
> > Subject: [PATCH] xen/acpi-processor: fix sparse warning
> > Subject: [PATCH] scsi: initio: fix sparse warnings
> > Subject: [PATCH] scsi: dc395x: fix sparse warning
> > Subject: [PATCH] scsi: eata: fix sparse warning
> > Subject: [PATCH] scsi: qla1280: fix sparse warnings
> > Subject: [PATCH] scsi: ips: fix sparse warnings
> > Subject: [PATCH] fbdev: via/via_clock: fix sparse warning
> > Subject: [PATCH] usb: gadget: fix sparse warnings
> > Subject: [PATCH] usb: gadget: fix sparse warnings
> > Subject: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings
> > Subject: [PATCH] xen-netback: fix sparse warning
> > Subject: [PATCH] thermal: int340x: fix sparse warning
> > Subject: [PATCH] vxge: fix sparse warning
> > Subject: Re: [PATCH] xen-netback: fix sparse warning
> > Subject: [PATCH] ixgbe: fix sparse warnings
> > Subject: [PATCH] samsung-laptop: fix sparse warning
> > Subject: [PATCH] x86: thinkpad_acpi.c: fix sparse warning
> > Subject: [PATCH] Sony-laptop: fix sparse warning
> >
> all right I have stopped the script to send any more patches fixing
> sparse warnings !
That's not the point at all {sigh}
The point is, if you are going to do fixes, also provide a valid subject
line too. Think of the people on the receiving end of your patch, they
are the most valuable and limited resource our community has right now.
You want to make it as _easy_ as possible for them to accept your
contribution. If you don't provide enough information, or drown them in
redundancy, or crappy patches, they will just get frustrated and drop
them all on the floor.
And _NEVER_ have automated scripts create patches and send them out. I
only know of ONE person/bot that gets away with this, and you are not
that person, sorry. It it not a script on the receiving end of your
output, so don't use a script to create a mess for them to dig through.
I want these types of fixes, but make it easy for us to accept them, not
hard, like Al is pointing out in very vivid detail. To respond to his
heartfelt plea and detailed instructions with a "fine, I'll just go
away!" is disrespectful.
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
